fix: return nil when HeaderTable.Get does not find a corresponding header #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aaronc not sure if this a known issue, but i think the behavior after this commit is more intuitive than before. Let me know if you have any questions. |
aaronc
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
This definitely makes sense and it should have been this way originally. Thanks for finding this and contributing @harry-stebbins-dailypay !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a datatable like this:
Before this commit, if you call
dt.HeaderTable().Get(0, "this_does_not_exist"), it returns the cell at1,0position in the datatable (i.e.example_value).After this commit, if you call
dt.HeaderTable().Get(0, "this_does_not_exist"), it returnsnil.